fix: Misaligned Caret and selection box for EditText + refactor SpriteFont glyph drawing logic#3058
Open
Eideren wants to merge 2 commits intostride3d:masterfrom
Open
fix: Misaligned Caret and selection box for EditText + refactor SpriteFont glyph drawing logic#3058Eideren wants to merge 2 commits intostride3d:masterfrom
Eideren wants to merge 2 commits intostride3d:masterfrom
Conversation
…eFont glyph drawing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
See title, fairly self explanatory.


Refactor came out both as a way to understand how font is drawn to figure out what was wrong, but also to improve throughput and fix some of the edge cases that came with the discrepancy in behavior between the different fonts.
Also changed the default selection color to look blue-ish instead of white; the text is already white by default, white on white isn't readable.
Related Issue
fix #2513
Types of changes
Checklist