fix: Replace static FocusedElement and more proactive UI service availability#3056
Open
Eideren wants to merge 2 commits intostride3d:masterfrom
Open
fix: Replace static FocusedElement and more proactive UI service availability#3056Eideren wants to merge 2 commits intostride3d:masterfrom
Eideren wants to merge 2 commits intostride3d:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
FocusedElement is a static field that is mutated throughout the lifetime of the program, two game instances may unknowingly fight over said field, using it as if it came from them. Which will ultimately throw, or at the very least cause unexpected issues through race-conditions between the two game instances.
Refactored the way in which the service registry is delivered to UI, providing users with the ability to enable a UI element as soon as it is added to the scene instead of after the first draw.
Related Issue
None
Types of changes
Checklist