feat: ImageElement can rotate the image by laske185 · Pull Request #3039 · stride3d/stride

laske185 · 2026-01-23T20:04:26Z

PR Details

The UI-element ImageElement has a new property Rotate that allows the image to be rotated. This internal changes the LocalMatrix of the element to rotate it. The property expects the angle in radians.

The GameStudio has a new editor control that allows the user to set the angle in degrees.

Related Issue

No issue created.

Types of changes

Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

My change requires a change to the documentation.
I have added tests to cover my changes.
All new and existing tests passed.
I have built and run the editor to try this change out.

Add a rotation property to the ImageElement that allows to rotate the image in radians. Introduce AngleEditor control for editing rotation properties in degrees while storing values in radians.

sources/presentation/Stride.Core.Presentation.Wpf/Controls/AngleEditor.cs

Ethereal77 · 2026-01-26T23:01:04Z

sources/engine/Stride.UI/Controls/ImageElement.cs

+        private void UpdateLocalMatrix()
+        {
+            if (Math.Abs(Rotation) < float.Epsilon)
+            {
+                LocalMatrix = Matrix.Identity;
+            }
+            else
+            {
+                LocalMatrix = Matrix.RotationZ(Rotation);
+            }
+        }


In this one however, I think the bot is wrong in supposing the local offset is lost,
The local matrix is taken in UIElement.UpdateWorldMatrix(), where the offsets are applied, and the result is used to compute the world-space matrix.

The local position is stored in the RenderOffsets property of the UIElement. The world matrix is calculated in the UpdateWorldMatrix method that adds the local matrix with the render offsets and size.

So I agree that the bot comment is not valid.

Corrected a spelling error in method names across multiple files, renaming UpateValueFromFloat to UpdateValueFromFloat. Updated all declarations, overrides, and usages to improve code clarity and consistency. No functional changes were made.

Ethereal77 · 2026-01-29T16:17:37Z

Looks good to me. Good job!

As the renaming was done in the editor and presentation parts, I think that doesn't merit an [Obsolete], but let's wait on other opinions on the matter.

laske185 · 2026-01-29T17:22:04Z

I found one issue with the UI property editor I want to fix.

…general template provider Replaced the custom RotationFloatPropertyTemplateProvider with a new, reusable TypeNameMatchTemplateProvider that matches both type and property name. Updated XAML to use this provider for "Rotation" float properties, simplifying and generalizing the approach for property-specific editors. This makes it easier to add similar editors in the future without extra provider classes.

laske185 · 2026-01-29T18:52:21Z

I moved the registration of the property editor from DefaultPropertyTemplateProviders.xaml to the UIPropertyTemplates.xml because it wasn't working reliably before.
And I replaced the custom RotationFloatPropertyTemplateProvider with a new, reusable TypeNameMatchTemplateProvider that matches both type and property name.

Eideren

Cool stuff, some very minor issues.
I would like to have @Kryptos-FR look at this too, to let us know whether there's anything we should be careful wrt UI logic and the avalonia refactor

...ces/editor/Stride.Core.Assets.Editor/View/TemplateProviders/TypeNameMatchTemplateProvider.cs

sources/engine/Stride.UI/Controls/ImageElement.cs

Replaces TypeNameMatchTemplateProvider with TypeAndPropertyNameMatchTemplateProvider in both XAML and C# to clarify that matching is based on both type and property name, not just type and name. Updates all relevant usages and class definitions accordingly.

Refactored the Rotation property and UpdateLocalMatrix method to use direct equality checks (==) instead of Math.Abs(... - ...) < float.Epsilon. This streamlines the code but may affect floating-point precision handling.

Refactored GetDisplayValue to remove special handling for negative zero and instead round the degree value to four decimal places for cleaner display.

...Stride.Core.Assets.Editor/View/TemplateProviders/TypeAndPropertyNameMatchTemplateProvider.cs

sources/engine/Stride.UI.Tests/Layering/ImageElementRotationTests.cs

sources/presentation/Stride.Core.Presentation.Wpf/Controls/AngleEditor.cs

sources/engine/Stride.UI/Controls/ImageElement.cs

Kryptos-FR · 2026-02-09T12:04:41Z

sources/presentation/Stride.Core.Presentation.Wpf/Themes/ThemeSelector.xaml

+            </Grid.ColumnDefinitions>
+            <Border Grid.Column="0" CornerRadius="4" Background="{StaticResource NormalBrush}" BorderThickness="1" BorderBrush="{StaticResource NormalBorderBrush}">
+              <DockPanel>
+                <TextBlock Text="°" Margin="0,0,3,0" MinWidth="12" VerticalAlignment="Center" TextAlignment="Center" Foreground="{StaticResource TextBrush}" />


I'm not sure about that part. We have other places where angles can be edited (e.g. the transform component) but we don't display the ° symbol there. So it's not consistent.

I removed it for consistency reasons, but I thought it would be good to show the user which unit is being acquired.

It's a good idea. But maybe we can discuss it on another PR after this one is merged. And propose a similar change for the RotationEditor (quaternion).

- Remove reference to "Silicon Studio Corp." in file headers. - Add notice about MIT license distribution and link to LICENSE.md. - Clarify licensing information; no functional code changes made.

- Update Rotation setter to use floating-point tolerance comparison. - Prevent unnecessary updates when new value is nearly equal to current. - Address floating-point precision issues for more reliable property changes.

- Removed Grid, Border, DockPanel, and degree symbol from the template. - Now uses only a NumericTextBox for a cleaner and more minimal UI. - Adjusted NumericTextBox margin from "3,0" to "2,0" for improved spacing. - Streamlines the AngleEditor appearance and reduces unnecessary elements.

feat: ImageElement can rotate the image

c11b8cc

Add a rotation property to the ImageElement that allows to rotate the image in radians. Introduce AngleEditor control for editing rotation properties in degrees while storing values in radians.

Ethereal77 reviewed Jan 26, 2026

View reviewed changes

sources/presentation/Stride.Core.Presentation.Wpf/Controls/AngleEditor.cs Outdated Show resolved Hide resolved

Ethereal77 reviewed Jan 26, 2026

View reviewed changes

laske185 marked this pull request as draft January 29, 2026 17:21

laske185 marked this pull request as ready for review January 29, 2026 18:52

Eideren reviewed Feb 1, 2026

View reviewed changes

Eideren requested a review from Kryptos-FR February 1, 2026 20:45

laske185 added 3 commits February 6, 2026 17:30

Simplify floating-point comparisons in ImageElement

e834138

Refactored the Rotation property and UpdateLocalMatrix method to use direct equality checks (==) instead of Math.Abs(... - ...) < float.Epsilon. This streamlines the code but may affect floating-point precision handling.

Simplify angle display value conversion and rounding

28273ea

Refactored GetDisplayValue to remove special handling for negative zero and instead round the degree value to four decimal places for cleaner display.

Kryptos-FR reviewed Feb 9, 2026

View reviewed changes

Kryptos-FR added enhancement New feature or request area-GameStudio area-UI labels Feb 9, 2026

laske185 added 3 commits February 9, 2026 16:01

docs(license): update copyright headers for MIT license

b03f1e9

- Remove reference to "Silicon Studio Corp." in file headers. - Add notice about MIT license distribution and link to LICENSE.md. - Clarify licensing information; no functional code changes made.

fix(ui-controls): improve Rotation property precision check

c0bef49

- Update Rotation setter to use floating-point tolerance comparison. - Prevent unnecessary updates when new value is nearly equal to current. - Address floating-point precision issues for more reliable property changes.

Kryptos-FR approved these changes Feb 9, 2026

View reviewed changes

Uh oh!

Conversation

laske185 commented Jan 23, 2026

PR Details

Related Issue

Types of changes

Checklist

Uh oh!

Uh oh!

Ethereal77 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

laske185 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Ethereal77 commented Jan 29, 2026

Uh oh!

laske185 commented Jan 29, 2026

Uh oh!

laske185 commented Jan 29, 2026

Uh oh!

Eideren left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kryptos-FR Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

laske185 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Kryptos-FR Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kryptos-FR Feb 9, 2026 •

edited

Loading