Update docs for Apollo Federation v1 deprecation#526
Open
bhavberi wants to merge 3 commits intostrawberry-graphql:mainfrom
Open
Update docs for Apollo Federation v1 deprecation#526bhavberi wants to merge 3 commits intostrawberry-graphql:mainfrom
bhavberi wants to merge 3 commits intostrawberry-graphql:mainfrom
Conversation
|
@bhavberi is attempting to deploy a commit to the Strawberry GraphQL Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Apollo Federation v1 guide warning block to clearly state that Federation v1 is no longer supported and to direct users to Federation v2 and the 0.285.0 breaking changes documentation for migration details. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the new warning text, the Federation v2 link has a double opening parenthesis (
[Federation v2]((/docs/guides/federation))) which will break the markdown and should be corrected to a single(/)pair. - Consider preserving a link to Apollo’s “What’s new in federation 2” page alongside the breaking changes link, as it can still provide valuable conceptual context for users migrating from v1 to v2.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the new warning text, the Federation v2 link has a double opening parenthesis (`[Federation v2]((/docs/guides/federation))`) which will break the markdown and should be corrected to a single `(`/`)` pair.
- Consider preserving a link to Apollo’s “What’s new in federation 2” page alongside the breaking changes link, as it can still provide valuable conceptual context for users migrating from v1 to v2.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apollo Federation v1 was deprecated in v0.285.0, but the Federation v1 docs don't show it. Updating the warning will help new users know about it.
Types of Changes
Issues Fixed or Closed by This PR
NA
Checklist
Summary by Sourcery
Documentation: