[Draft] add: tools for creating combined permissions#749
Draft
iamcrookedman wants to merge 4 commits intostrawberry-graphql:mainfrom
Draft
[Draft] add: tools for creating combined permissions#749iamcrookedman wants to merge 4 commits intostrawberry-graphql:mainfrom
iamcrookedman wants to merge 4 commits intostrawberry-graphql:mainfrom
Conversation
Contributor
Reviewer's GuideImplements a composable permission framework with logical operators (AND, OR, NOT) and adds a GraphQL extension to apply multiple permission classes per field. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
3 tasks
Contributor
There was a problem hiding this comment.
Hey @iamcrookedman - I've reviewed your changes - here's some feedback:
- Consider normalizing operand order in OperandHolder for commutative operators like AND/OR so that A & B and B & A produce equivalent holders.
- Add eq and hash implementations to SingleOperandHolder to match OperandHolder and ensure permission expressions can be reliably compared and used as dict keys.
- Add type hints or runtime validation in HasPermissionClasses to ensure that permission_classes is an iterable of BasePermission subclasses to catch misconfigurations early.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
added 2 commits
May 21, 2025 13:05
…to feature/combined-permissions
39043bd to
d824d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Add support for composing permissions with boolean operators and enforce multiple permission classes in GraphQL extensions
New Features: