For issue #42

[mcioffi]

Fixes

TL;DR — Addresses #42

• Now accounts for both CompositeIngredientAmount and IngredientAmount in webapp parser
• Makes flask's jsonify more context aware for Fraction/Unit by extending Flask's DefaultJSONProvider

[strangetom]

Thanks @mcioffi.

Is it possible to visually associate the parts of a CompositeIngredientAmount when displaying to show that they are associated? The subtractive attribute of CompositeIngredientAmount might be helpful in deciding how display it.

[mcioffi]

Does a tooltip suffice? Tooltips/badges are currently used in the parser table for amounts, e.g. singular [1], prepared ingredient [P], approximate [~], and can do something similar for composites, if you have a chararcter or symbol in mind, e.g. composite ingredient [C].

Because the list is decomposed down to just a list of IngredientAmount when passed back from server to client, I have to find a way to identify it as being part of CompositeIngredientAmount. Do you know if there is ever a scenario where a parsed sentence has a combo of IngredientAmount and CompositeIngredientAmount, or do they all just roll up to CompositeIngredientAmount. Any example ingredient sentences for that scenario if it holds?

[strangetom]

It is possible to have a mixture of CompositeIngredientAmounts and IngredientAmounts, for example

1/4 cup plus 1 tablespoon (25 g) unsweetened dark cocoa powder

What is you continued decomposing to IngredientAmounts but grouped them where they're part of a CompositeIngredientAmount e.g.

[
   [
      IngredientAmount(),
      IngredientAmount()
   ],
   IngredientAmount()
]

and then any sublists with more than 1 item would indicate that they're associated.

[mcioffi]

Does this suffice from visual perspective on the parser table?

[strangetom]

That looks like it will work fine 👍

[mcioffi]

Should be ready to test. I had been trying to get the parser to return both a CompositeIngredient with some other badges that identify attributes like singular, prepared, or approximate to see if the different badges/tooltips render correctly alongside each other. I tried the following, but the prepared ingredient gets lost when composite ingredients are identified. It might be a syntax that the trainer hasn't seen before in this context, but figured to show an example.

Has prepared ingredient
3 cups (750 ml) strained beef or vegetable stock

Adds composite ingredient syntax to prepared ingredient sentence
3 cups (750 ml) plus 0.2 cups (47 ml) strained beef or vegetable stock

[strangetom]

Thanks, that seems like it works fine.

The flags are set during the post-processing based on patterns of labels and tokens. 3 cups (750 ml) plus 0.2 cups (47 ml) strained beef or vegetable stock does not contain a supported pattern, but something like 3 cups plus 0.2 cups (797 ml) strained beef or vegetable stock does work:

It does look like there could some improvements here. About 3 cups plus 0.2 cups (797 ml) strained beef or vegetable stock should have the amounts flagged as approximate, but doesn't.