Skip to content

Fix Offset not found PHPStan error in Image class#11

Open
jwhulette wants to merge 1 commit intostoryblok:masterfrom
jwhulette:fix-phpstan-errors
Open

Fix Offset not found PHPStan error in Image class#11
jwhulette wants to merge 1 commit intostoryblok:masterfrom
jwhulette:fix-phpstan-errors

Conversation

@jwhulette
Copy link
Copy Markdown

This pull request makes small improvements to type safety in the Image.php file by adding more precise type annotations for regular expression match results. These changes help clarify the expected structure of the $matches array and can assist with static analysis tools.

  • Type annotations for regex match results:
    • Added a PHPDoc type annotation for the $matches array in the constructor to specify it contains two string elements.
    • Added a PHPDoc type annotation for the $matches array in the focalPoint method to specify it contains four string elements.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (36e088c) to head (5c7cae2).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage     99.39%   99.39%           
  Complexity       54       54           
=========================================
  Files             1        1           
  Lines           165      165           
=========================================
  Hits            164      164           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants