Skip to content

WIP ACM-23889 more issues#5526

Open
KevinFCormier wants to merge 2 commits intostolostron:mainfrom
KevinFCormier:ACM-23889-more-issues
Open

WIP ACM-23889 more issues#5526
KevinFCormier wants to merge 2 commits intostolostron:mainfrom
KevinFCormier:ACM-23889-more-issues

Conversation

@KevinFCormier
Copy link
Contributor

📝 Summary

Ticket Summary (Title):
Resolve failing Sonar quality gate for ACM console

Ticket Link:
https://issues.redhat.com/browse/ACM-23889

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

🗒️ Notes for Reviewers

Addresses more Sonar issues. See commit messages for problem description.

Signed-off-by: Kevin Cormier <kcormier@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kevin Cormier <kcormier@redhat.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2026

@KevinFCormier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud cd72e05 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@KevinFCormier KevinFCormier changed the title ACM-23889 more issues WIP ACM-23889 more issues Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant