ACM-27053 Remove validation for generators in the ApplicationSet YAML editor#5471
Conversation
… editor Signed-off-by: John Swanke <[email protected]>
|
/hold |
|
@jeswanke Thanks for validating all the generators! The code looks good. One issue is that we still get a validation error about the missing "clusterDecisionResource" generator when using matrix generators. Can you remove this validation error as well? Thanks! |
Signed-off-by: John Swanke <[email protected]>
| import { CreateArgoResources } from './CreateArgoResources' | ||
| import { MultipleSourcesSelector } from './MultipleSourcesSelector' | ||
| import { SourceSelector } from './SourceSelector' | ||
| import { useYamlResources } from '../../routes/Applications/Applications' |
There was a problem hiding this comment.
Looks like this function doesn't exist:
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
…-27053-Remove-validation-for-generators-in-the-ApplicationSet-YAML-editor Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
|
@jeswanke I think overall the code looks great! The only minor nit I have is to make the generator inputs show the placeholder text instead of a sample input value. You can even handle this in a bug as well. Thanks! |
|
/lgtm |
|
/retest |
Signed-off-by: John Swanke <[email protected]>
…-27053-Remove-validation-for-generators-in-the-ApplicationSet-YAML-editor Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
Signed-off-by: fxiang1 <[email protected]>
Add back changes from PR 5508
Signed-off-by: John Swanke <[email protected]>
…cationSet-YAML-editor' of https://github.com/jeswanke/console into ACM-27053-Remove-validation-for-generators-in-the-ApplicationSet-YAML-editor Signed-off-by: John Swanke <[email protected]>
Signed-off-by: John Swanke <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fxiang1, jeswanke The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
@jeswanke: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
… editor (stolostron#5471) * ACM-27053 Remove validation for generators in the ApplicationSet YAML editor Signed-off-by: John Swanke <[email protected]> * ACM-27053 Support all Argo CD generators in the ApplicationSet Wizard Signed-off-by: John Swanke <[email protected]> * backup Signed-off-by: John Swanke <[email protected]> * backup Signed-off-by: John Swanke <[email protected]> * backup Signed-off-by: John Swanke <[email protected]> * backup Signed-off-by: John Swanke <[email protected]> * fix tests Signed-off-by: John Swanke <[email protected]> * fix sync bug Signed-off-by: John Swanke <[email protected]> * fix checks Signed-off-by: John Swanke <[email protected]> * prettier Signed-off-by: John Swanke <[email protected]> * oops Signed-off-by: John Swanke <[email protected]> * oop[s Signed-off-by: John Swanke <[email protected]> * oops Signed-off-by: John Swanke <[email protected]> * oops Signed-off-by: John Swanke <[email protected]> * fix lint Signed-off-by: John Swanke <[email protected]> * fix coverage Signed-off-by: John Swanke <[email protected]> * Put back changes from PR 5508 Signed-off-by: fxiang1 <[email protected]> * linjt Signed-off-by: John Swanke <[email protected]> * fix test Signed-off-by: John Swanke <[email protected]> --------- Signed-off-by: John Swanke <[email protected]> Signed-off-by: fxiang1 <[email protected]> Co-authored-by: fxiang1 <[email protected]>
3 participants
Signed-off-by: John Swanke [email protected]
📝 Summary
Ticket Summary (Title):
Ticket Link:
Type of Change:
✅ Checklist
General
ACM-12340 Fix bug with...)If Feature
If Bugfix
🗒️ Notes for Reviewers