[Feature] Group unhandled paths#91
Conversation
I see what you mean. I think it's ok for |
As a user of the exporter, I would prefer that |
[Feature] Add `group_unhandled_paths` Option to Enhance `filter_unhandled_paths` Functionality #91
@stephenhillier I started working on the update discussed in #82 and I am going with
__unknown__value in the end as the_symbol is unlikely to conflict with some actual api endpoint.As I was finishing up the changes, it seemed quite impractical to support both
filter_unhandled_pathsandgroup_unhandled_pathsoptions as only one of these is applicable. It leads to weird situations like, if you want to enablegroup_unhandled_pathsyou also need to explicitly disablefilter_unhandled_pathsas it is enabled by default. Maybe 2 different flags are not the right way to go? Maybe an option likeunhandled_paths_strategyaccepting string valuesignore(replacement forfilter_unhandled_paths),group(replacement forgroup_unhandled_paths), orunique(replacement for setting bothfilter_unhandled_pathsandgroup_unhandled_pathstoFalse, but not sure about the nameunique) to decide how to handle these situations. I think this would be a better way to go, but if we remove thefilter_unhandled_paths, it will be a breaking change.If we go with
unhandled_paths_strategyoption, the default value could be actually based ongroup_pathsoption. If enabled, the default value would begroup, if disabled, default value could beunique.If we go with
group_unhandled_pathsoption, what should happen if bothfilter_unhandled_pathsandgroup_unhandled_pathsare set toTrue? I threw an error, but I am not sure if thats the right way to go.I pushed the original solution as a draft and we can discuss which direction we should go.
Going with a new flag would be least disruptive to users as it does not introduce any breaking changes, but seems quite unintuitive when setting up the configuration (disabling one flag to be able to enable another one).