Rb192

[ryskajakub]

So this is the reworked pull-request.

It contains three issues:
#194
ryskajakub#1
ryskajakub#2

• I also did some refactoring along the way as I noticed, that the default arguments to the eo_get_venues_map are specified two times.
• I used tabs instead of spaces everywhere
• I also ran the grunt uglify task for minification of the frontend.js file, all the other .js files got changed for some reason, too.

[stephenharris]

Eeep, sorry, I've only just got round to looking at this. (Pro 1.8.0 is now out the door, so I'm focussing on the next major of Event Organiser).

Could I ask that you make the PR on the develop, I'm currently restructuring on how the repo is organised. The master branch will (eventually) be the "stable" version of the plug-in, with each commit being a release. (Also current develop branch has minified resources removed from version control, there should never have been there in the first place.)

Also, with regards to defining functions, prefix functions with eventorganiser_ (if it's not for public user - e.g. most 'helper' functions) or eo_ if it is for public use. Also functions should not be defined within functions, and general helper-functions should live in event-organiser-utility-functions.php. I'm thinking in particular cast_to_boolean_if_possible.

I'll add some additional comments

Thanks for your help :).

[stephenharris]

I like how the boolean keys are treated, but I think the defaults should be an array rather than a separate function. That way the default values are obvious within the function.

[stephenharris]

Ah, I see, defaults are used in two separate places. I see the reasoning now...

The default values, however are different for the function/shortcode (tooltip as far as I can tell).