all: Adopt recommended linters in CI and address the problems pointed by them#142

Merged

marcelosalloum merged 27 commits intomainfrom

marcelo/polish-project-config-and-CI

Apr 18, 2025

Commits on Apr 15, 2025

Commits on Apr 16, 2025

Handle previously unhandled errors and make it explicit that some utils functions are meant to be used from within tests by requiring a test object and handling the internal error inside of it.
marcelosalloum
committed
Start handling a bunch of previously unhandled errors in the unit tests. This exposed some issues that will be handled in the next commit.
marcelosalloum
committed
Fix `GET /tss/transactions/{hash}` that was broken and the issue got surfaced thanks to better error handling.
marcelosalloum
committed
Fix Sentry tests that were broken but not visibly broken.
marcelosalloum
committed
Make sure all mocks live under a mocks.go file, for consistency.
marcelosalloum
committed
Fix shadowed variable issues that raised after addressing other linter errors
marcelosalloum
committed
Rename function.
marcelosalloum
committed
Fix installation command of golangci-lint
marcelosalloum
committed
Polish.
marcelosalloum
committed
Merge branch 'main' into marcelo/polish-project-config-and-CI
marcelosalloum
authored
Fixes after merge.
marcelosalloum
committed
Drastically reduce unit tests run time from 92s to 23s (4 times faster!) by allowing retryCounts and retryIntervals to be (optionally) parametrized.
marcelosalloum
committed
Wrapped missing errors, for better traceability.
marcelosalloum
committed
Fix async issue causing tests to fail intermittently.
marcelosalloum
committed
Move MockChAccCmdServiceInterface to the mocks.go file, for consistency, and start using the EXPECT() method, which has better syntax.
marcelosalloum
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: Adopt recommended linters in CI and address the problems pointed by them#142

all: Adopt recommended linters in CI and address the problems pointed by them#142
marcelosalloum merged 27 commits intomainfrom
marcelo/polish-project-config-and-CI

Commits on Apr 15, 2025

Use gotestsum for better visibility on the tests

Add test coverage validation to the CI.

Add linter config.

Reorganize imports with `goimports -local "github.com/stellar/wallet-backend" -l -w .`

Apply cache to go-install for improved performance.

Add checks for shadow and goimports, and upgrade the version from other checks.

Fix all variable shadowing issues

Remove call to `db.RunInTransaction`, since it was not using a database transaction, and there would be no value in doing so. Kinda bogus code.

Fix several linter warnings.

Fix several linter warnings. [2]

Fix tests that broke after linter-related changes.

Bump golangci-lint version in the GH Workspace.

Commits on Apr 16, 2025

Handle previously unhandled errors and make it explicit that some utils functions are meant to be used from within tests by requiring a test object and handling the internal error inside of it.

Start handling a bunch of previously unhandled errors in the unit tests. This exposed some issues that will be handled in the next commit.

Fix `GET /tss/transactions/{hash}` that was broken and the issue got surfaced thanks to better error handling.

Fix Sentry tests that were broken but not visibly broken.

Make sure all mocks live under a mocks.go file, for consistency.

Fix shadowed variable issues that raised after addressing other linter errors

Rename function.

Fix installation command of golangci-lint

Polish.

Merge branch 'main' into marcelo/polish-project-config-and-CI

Fixes after merge.

Drastically reduce unit tests run time from 92s to 23s (4 times faster!) by allowing retryCounts and retryIntervals to be (optionally) parametrized.

Wrapped missing errors, for better traceability.

Fix async issue causing tests to fail intermittently.

Move MockChAccCmdServiceInterface to the mocks.go file, for consistency, and start using the EXPECT() method, which has better syntax.