Add a randomized test for 'frozen' DEX offers.#5174
Merged
dmkozh merged 1 commit intostellar:masterfrom Mar 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new randomized acceptance test to validate that offers owned by accounts with frozen ledger keys do not perturb DEX matching outcomes (i.e., matching results and account balance deltas remain identical to a baseline run without frozen offers).
Changes:
- Introduces a randomized market simulation that runs twice per iteration (baseline vs. with frozen offers) and compares resulting balance deltas for taker + active makers.
- Adds aggregate assertions intended to ensure the test actually exercised both successful transactions and frozen-offer removals.
Removal of offers that would affect frozen entries from DEX has already been covered in a simple smoke test. This is a more robust randomized test that ensures that DEX behavior is the same both with and without 'frozen' offers.
sisuresh
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removal of offers that would affect frozen entries from DEX has already been covered in a simple smoke test. This is a more robust randomized test that ensures that DEX behavior is the same both with and without 'frozen' offers.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)