Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
This looks good, but I think we might keep this for the next major version. As far as I understand, there's nothing critical that's needed. Let me know if I'm missing something.
Contributor
Author
|
I don't think so. This was just in response to stellar/rs-soroban-sdk#1658. It doesn't look like I'll leave the PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the
stellar-strkeypackageWhy
So it can be updated in the soroban-sdk without an old version also being included
Known limitations
None