Add EMTA KMD draft tooling and harden EMTA/LHV session persistence - #11
Add EMTA KMD draft tooling and harden EMTA/LHV session persistence#11TonisOrmisson wants to merge 4 commits into
Conversation
|
Thank you for your contribution! Before we can merge it, we need you to agree to the Contributor License Agreement. Please read it, then post the following comment in this PR to sign: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
| @@ -2,9 +2,7 @@ name: CI | |||
|
|
|||
There was a problem hiding this comment.
nit: I appreciate those improvements but maybe worth another PR to keep diff cleaner? WDYT?
| } | ||
| } | ||
|
|
||
| func loadSessionData() ([]byte, error) { |
There was a problem hiding this comment.
blocking: I think this change deserves more conversation as we're changing from encrypted keychain to plaintext storage of the credentials.
IMHO worth discussing in more detail on another issue and PR.
stefanoamorelli
left a comment
There was a problem hiding this comment.
thanks a lot @TonisOrmisson! Really appreciate the kmd implementation. I left a couple of comments, overall if we could scope down this PR just for the kmd feature to avoid mix of concerns it would be fantastic.
This PR adds KMD support to emta-cli so agents can list declarations, read draft data, update the KMD main form, read/
update/delete INF A and INF B rows, and use a separate guarded submit command. It also hardens EMTA/LHV session handling
for WSL/Linux by adding file-based fallback session storage and updating the current EMTA govsso + customer-kmd2 flow.
Main changes:
Validation:
Notes: