Skip to content

test: add special cases tests in math/base/special/xlog1py #9503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashish-066 wants to merge 5 commits into
base: develop
Choose a base branch
from
+23 −0
Open

test: add special cases tests in math/base/special/xlog1py #9503

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f3e63a
test: add special value tests for log1pmx
ashish-066 Jan 2, 2026
343653f
test: add infinity handling tests for xlog1py
ashish-066 Jan 2, 2026
d1b01fc
style: add blank line between test blocks
ashish-066 Jan 2, 2026
092f3ca
Discard changes to lib/node_modules/@stdlib/math/base/special/log1pmx…
kgryte Jan 3, 2026
f3ad675
test: add infinity handling tests for xlog1py
ashish-066 Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions lib/node_modules/@stdlib/math/base/special/xlog1py/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,27 @@ tape( 'the function evaluates `x * ln(y+1)` for large `x` and `y`', function tes
}
t.end();
});

tape( 'the function handles infinite values', function test( t ) {
Comment on lines 177 to +179
Copy link
Copy Markdown
Contributor

@Lokeshranjan8 Lokeshranjan8 Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a blank line before this function definition. Please add one.

Copy link
Copy Markdown
Author

@ashish-066 ashish-066 Jan 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lokeshranjan8 added

var v;

v = xlog1py( Infinity, 1.0 );
Copy link
Copy Markdown
Member

@kgryte kgryte Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments:

  1. All test messages should be returns expected value. No need for custom bespoke test messages.
  2. We don't use Infinity and -Infinity. We use associated constants packages. See other tests in math/base/special.

Copy link
Copy Markdown
Author

@ashish-066 ashish-066 Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done changes after checking other function tests

t.strictEqual( v, Infinity, 'Infinity * finite positive returns Infinity' );

v = xlog1py( Infinity, 0.0 );
t.strictEqual( isnan( v ), true, 'Infinity * 0 returns NaN' );

v = xlog1py( Infinity, -1.0 );
t.strictEqual( v, -Infinity, 'Infinity * negative returns -Infinity' );

v = xlog1py( 2.0, Infinity );
t.strictEqual( v, Infinity, 'finite positive * Infinity returns Infinity' );

v = xlog1py( -2.0, Infinity );
t.strictEqual( v, -Infinity, 'finite negative * Infinity returns -Infinity' );

v = xlog1py( 0.0, Infinity );
t.strictEqual( v, 0.0, '0 * Infinity returns 0' );

t.end();
});