Add gallery sorting by performer age#6879
Open
slick-daddy wants to merge 6 commits intostashapp:developfrom
Open
Add gallery sorting by performer age#6879slick-daddy wants to merge 6 commits intostashapp:developfrom
slick-daddy wants to merge 6 commits intostashapp:developfrom
Conversation
…pt-develop Expose and filter gallery o_counter (image o_counter sum)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the ability to sort galleries by performer age so users can find galleries based on the youngest or oldest performers associated with a gallery. Related #2956 and #5788
Description
performer_agetogallerySortOptionsand implement sorting logic insetGallerySortthat uses a subquery to compute performer age withMIN/MAXaggregation andCOALESCEfallbacks based on sort direction.performer_ageascending and descending toTestGalleryQuerySortingingallery_test.go.performer_ageentry tosortByOptionsand creatingPerformerAgeCriterionOptioninui/v2.5/src/models/list-filter/galleries.ts.Testing
go test ./pkg/sqlite -run TestGalleryQuerySortingwhich includes the newperformer_agecases and it passed.go test ./...and it completed successfully.The only problem is this PR includes one of my open PR's as well. I assumed it will be merged as well. It can be removed.
Linter may fail due to high integer in fallback part but it can changed to any high number, the result will be same.