Expose and filter gallery o_counter (image o_counter sum)#6878
Open
slick-daddy wants to merge 1 commit intostashapp:developfrom
Open
Expose and filter gallery o_counter (image o_counter sum)#6878slick-daddy wants to merge 1 commit intostashapp:developfrom
slick-daddy wants to merge 1 commit intostashapp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for summing up image
o_countervalues across a gallery and lets you filter galleries based on that total.Related #2836 and #6088
Description
o_counterfield to the Gallery GraphQL type and updated the UI fragments so you can actually queryGallery.o_counter.OCountertoGalleryFilterTypeand wired up a filter handler (galleryOCounterCriterionHandler) that runs a SQL subquery to computeSUM(images.o_counter)per gallery, then applies integer criteria through the existinggetIntCriterionWhereClause.OCountByGalleryIDtoImageStore, which grabsCOALESCE(SUM(o_counter), 0)for images tied to a gallery. Also updated theImageCounterinterface and hooked up thegalleryResolver.OCounterresolver to call it.OCountByGalleryID, and exposedo_counteras a filterable option in the UI list filters.