Skip to content

[ci] add explicit flow for makefile, add make install#6877

Open
feederbox826 wants to merge 4 commits intostashapp:developfrom
feederbox826:ci-gha
Open

[ci] add explicit flow for makefile, add make install#6877
feederbox826 wants to merge 4 commits intostashapp:developfrom
feederbox826:ci-gha

Conversation

@feederbox826
Copy link
Copy Markdown
Member

@feederbox826 feederbox826 commented Apr 30, 2026

  • replaces explicit run in build.yml with make pre-ui
  • remove NOLEGACY (was removed in ui package updates sprint 1 #6777)
  • add make install to comply with homebrew
    • C:\Users\$Username\bin\stash-win.exe on windows (tested)
    • ~/.local/bin/stash on linux (untested)

supercedes #5701
closes #5673
closes #5674
related: Homebrew/homebrew-core#203821

will open up a PR once release hits so they're in the build artifacts

Comment thread Makefile Outdated
RM := del /s /q
RMDIR := rmdir /s /q
NOOP := @@
PREFIX := $(USERPROFILE)\\bin
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent level needs fixing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to 2 spaces

Comment thread Makefile Outdated
RM := rm -f
RMDIR := rm -rf
NOOP := @:
PREFIX := $(HOME)/.local
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent level needs fixing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to 2 spaces

@WithoutPants WithoutPants added the chore Tedious admin work or code refactoring label May 3, 2026
@WithoutPants WithoutPants added this to the Version 0.32.0 milestone May 3, 2026
@feederbox826 feederbox826 requested a review from WithoutPants May 4, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Tedious admin work or code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] make release fails when building in parallel [Feature] Add make install target

2 participants