add support for half-float and probe for format renderability, closes…#15
Open
neomantra wants to merge 1 commit into
Open
add support for half-float and probe for format renderability, closes…#15neomantra wants to merge 1 commit into
neomantra wants to merge 1 commit into
Conversation
…tackgl#11 Adds two new `options`: * like `options.float`, `options.halfFloat` fails if it cannot create the half-float texture * like `options.preferFloat`, `options.preferHalfFloat` will try half-float, then float, then fail to 8-bit. * `options.preferFloat` now tries a half-flat before failing to 8-bit The function `isFormatRenderable` checks if a given format can actually be rendered to by attaching a texture to a framebuffer. Checking the WebGL extension alone is insufficient due to variations in implementations (e.g. iOS supports OES_texture_float, but only for reading, not for writing). As this is a FBO and thus intended for writing, this extra check is important.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… #11
Adds two new
options:options.float,options.halfFloatfails if it cannot createthe half-float texture
options.preferFloat,options.preferHalfFloatwill tryhalf-float, then float, then fail to 8-bit.
options.preferFloatnow tries a half-flat before failing to 8-bitThe function
isFormatRenderablechecks if a given format canactually be rendered to by attaching a texture to a framebuffer.
Checking the WebGL extension alone is insufficient due to variations
in implementations (e.g. iOS supports OES_texture_float, but only
for reading, not for writing). As this is a FBO and thus intended for
writing, this extra check is important.