Inject the Config in the Runner constructor#3882
Open
BafS wants to merge 1 commit intosquizlabs:masterfrom
Open
Inject the Config in the Runner constructor#3882BafS wants to merge 1 commit intosquizlabs:masterfrom
BafS wants to merge 1 commit intosquizlabs:masterfrom
Conversation
Contributor
|
Marking as "Close candidate" - see the discussion in #3697 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inject the configuration object in the constructor instead of creating the instance without having the ability to change it.
Currently it's not possible to change the configuration because it's using in a "black box" way. This PR proposes to use dependency injection to have more control over it when using the library in a programmatic way.
Suggested changelog entry
Related issues/external references
Fixes #
Types of changes
PR checklist
package.xmlfile.