Add support for diacritics in camel caps names#3532
Open
julienfalque wants to merge 1 commit intosquizlabs:masterfrom
Open
Add support for diacritics in camel caps names#3532julienfalque wants to merge 1 commit intosquizlabs:masterfrom
julienfalque wants to merge 1 commit intosquizlabs:masterfrom
Conversation
jrfnl
reviewed
Jul 14, 2023
Contributor
jrfnl
left a comment
There was a problem hiding this comment.
@julienfalque Sorry it's taken so long before this review.
I really like the principle of this chance, however, I do have some questions.
- If I remember correctly, it was possible at some point to compile the PCRE extension without UTF8 support. Should that be taken into account as this package still supports PHP 5.4 ?
- Is there a specific reason to use the POSIX character classes instead of the escape sequences for Unicode properties ?
IIRC (again) the POSIX character classes may not always support Unicode depending on the PCRE version. Should that be taken into account as this package still supports PHP 5.4 ? - Will using the Unicode PCRE option for all uses of this function (while the majority of code is likely using ASCII based names) have an impact on performance ?
Author
I would say this should be taken into account but I'm not sure there's a reliable way to detect the (lack of) UTF-8 support.
No specific reason, I can use
To be honest I don't know. I guess it will have a negative impact but barely noticeable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.