Extend InputMethodManager workaround to API level 35#2737
Open
jjliu15 wants to merge 1 commit intosquare:mainfrom
Open
Extend InputMethodManager workaround to API level 35#2737jjliu15 wants to merge 1 commit intosquare:mainfrom
jjliu15 wants to merge 1 commit intosquare:mainfrom
Conversation
Member
|
@jjliu15 can you share a sample leaktrace on api 35? |
Author
|
@pyricau added to the description. I verified locally that this PR fixes the leak |
Author
|
Hi @pyricau, could you take another look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example leak trace: