Skip to content

HprofPrimitiveArrayStripper clears out primitive wrapper value fields #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pyricau wants to merge 3 commits into
base: main
Choose a base branch
from
Open

HprofPrimitiveArrayStripper clears out primitive wrapper value fields #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87fba50
Clear values in primitive wrappers
pyricau Jan 8, 2025
51087fc
Add ability to delete input file directly into HprofPrimitiveArrayStr…
pyricau Jan 8, 2025
9a58fb7
no idea what this all was about
pyricau Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions ...anary/leakcanary-android-release/src/main/java/leakcanary/internal/RealHeapAnalysisJob.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,24 +239,20 @@ internal class RealHeapAnalysisJob(
checkStopAnalysis("stripping heap dump")
}

var openCalls = 0
val deletingFileSourceProvider = StreamingSourceProvider {
openCalls++
sensitiveSourceProvider.openStreamingSource().apply {
if (openCalls == 2) {
// Using the Unix trick of deleting the file as soon as all readers have opened it.
// No new readers/writers will be able to access the file, but all existing
// ones will still have access until the last one closes the file.
SharkLog.d { "Deleting $sourceHeapDumpFile eagerly" }
sourceHeapDumpFile.delete()
}
}
}

val strippedHprofSink = strippedHeapDumpFile.outputStream().sink().buffer()
val stripper = HprofPrimitiveArrayStripper()

stripper.stripPrimitiveArrays(deletingFileSourceProvider, strippedHprofSink)
stripper.stripPrimitiveArrays(
hprofSourceProvider = sensitiveSourceProvider,
hprofSink = strippedHprofSink,
onDoneOpeningNewSources = {
// Using the Unix trick of deleting the file as soon as all readers have opened it.
// No new readers/writers will be able to access the file, but all existing
// ones will still have access until the last one closes the file.
SharkLog.d { "Deleting $sourceHeapDumpFile eagerly" }
sourceHeapDumpFile.delete()
}
)
}

private fun analyzeHeapWithStats(heapDumpFile: File): Pair<HeapAnalysis, String> {
Expand Down
Loading
Loading