Skip to content

Fix/issue15 chat crash (#15) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andinux merged 3 commits into from
Nov 11, 2025
Merged

Fix/issue15 chat crash (#15) #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec505d7
fix: add ggml-blas support for macOS build
andinux Nov 7, 2025
2fb8761
fix: add context validation to llm_chat_create function
andinux Nov 7, 2025
6300eef
revert commit ec505d7: instead, use the right options in LLAMA env va…
andinux Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,4 +348,4 @@ help:
@echo " xcframework - Build the Apple XCFramework"
@echo " aar - Build the Android AAR package"

.PHONY: all clean test extension help version xcframework aar
.PHONY: all clean test extension help version xcframework aar
7 changes: 7 additions & 0 deletions src/sqlite-ai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,6 +1476,11 @@ static void llm_text_generate (sqlite3_context *context, int argc, sqlite3_value
// MARK: - Chat -

static bool llm_chat_check_context (ai_context *ai) {
if (!ai || !ai->ctx) {
sqlite_common_set_error(ai ? ai->context : NULL, ai ? ai->vtab : NULL, SQLITE_MISUSE, "No context found. Please call llm_context_create() before llm_chat_create().");
return false;
}

// check sampler
if (!ai->sampler) {
llm_sampler_check(ai);
Expand Down Expand Up @@ -1862,6 +1867,8 @@ static void llm_chat_free (sqlite3_context *context, int argc, sqlite3_value **a
}

static void llm_chat_create (sqlite3_context *context, int argc, sqlite3_value **argv) {
if (llm_check_context(context) == false) return;

ai_context *ai = (ai_context *)sqlite3_user_data(context);

// clean-up old chat (if any)
Expand Down
Loading