Setting 'server.servlet.session.cookie.partitioned' to false still emits the 'Partitioned' cookie attribute#50781
Merged
bclozel merged 1 commit intoJun 18, 2026
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
philwebb
added
type: regression
Member
|
See #50201 |
The session cookie's Partitioned attribute was set to "" for any non-null value, so an explicit `partitioned=false` was rendered the same as `true`. PropertyMapper.to() only filters null, so Boolean.FALSE reached the consumer and the attribute was always set. Use whenTrue() so the attribute is set only when partitioned is true, leaving false and unset to fall through to the container default. Closes spring-projectsgh-50781 Signed-off-by: Lee JiWon <dlwldnjs1009@gmail.com>
bclozel
force-pushed
the
fix-partitioned-session-cookie-false
branch
from
c335233 to
4b542ef
Compare
Member
|
Thanks for your contribution @dlwldnjs1009 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50774. This regressed from the
partitioned=truefix in #50201. An explicitserver.servlet.session.cookie.partitioned=falsestill emits; Partitioned, becausePropertyMapper.to()only filtersnulland the lambda set thePartitionedattribute to""for any non-null value.Changes
ServletContextInitializersuseswhenTrue()so the attribute is set only whenpartitionedistrueTesting
AbstractServletWebServerFactoryTests.sessionCookieNotPartitionedAttribute(new, header-level)AbstractServletWebServerFactoryTests.sessionConfiguration(assertion updated toisNull())