Support for multi module gradle builds#1288
Draft
lnavarette wants to merge 1 commit intospring-io:mainfrom
Draft
Support for multi module gradle builds#1288lnavarette wants to merge 1 commit intospring-io:mainfrom
lnavarette wants to merge 1 commit intospring-io:mainfrom
Conversation
|
@lnavarette Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
Any progress on that PR/ topic @wilkinsona, @snicoll ? This would be a great addition to Spring Initializr. I'll be interested in contributing as well, if needed. |
Contributor
|
Unfortunately not, @tinesoft. We have a number of other things on our plates at the moment which are of higher priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change partially resolves #663
High level overview of the changes:
BuildSystemalready had methods for getting main/test source roots. I have updated a few of the standardProjectContributors to use that so that I could extend theBuildSystemto be the source of truth for whether it's a single or multi module build.BuildSystemto support configuration of a module (other than root module) to hold the application, and it now provides agetApplicationModuleRootso thatProjectContributors can grab that if they want to put files in the application module - regardless of whether it's a single or multi project build.ProjectDescriptionCustomizerto inject theBuildSystemimplementationI'd like feedback on:
BuildSystemwas the "correct" thing to extend to add this functionality or if there may be a better place. It seemed clean enough but in a few places I needed to introduce it as a dependency for another class.ProjectDescriptionCustomizeracceptable?