Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions release-please-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"src/Spotify.Confidence.Sdk/Spotify.Confidence.Sdk.csproj",
"src/Spotify.Confidence.OpenFeature/Spotify.Confidence.OpenFeature.csproj",
"tests/Spotify.Confidence.Sdk.Tests/ConfidenceClientTests.cs",
"unity-sdk/Runtime/Providers/ConfidenceApiClient.cs",
{
"type": "json",
"path": "unity-sdk/package.json",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@

<ItemGroup>
<Compile Include="..\..\unity-sdk\Runtime\Providers\ConfidenceEndpointUrls.cs" Link="Unity\ConfidenceEndpointUrls.cs" />
<Compile Include="..\..\unity-sdk\Runtime\Core\ErrorCode.cs" Link="Unity\Core\ErrorCode.cs" />
<Compile Include="..\..\unity-sdk\Runtime\Core\Reason.cs" Link="Unity\Core\Reason.cs" />
<Compile Include="..\..\unity-sdk\Runtime\Telemetry\Telemetry.cs" Link="Unity\Telemetry\Telemetry.cs" />
<Compile Include="..\..\unity-sdk\Runtime\Telemetry\TelemetryEnums.cs" Link="Unity\Telemetry\TelemetryEnums.cs" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
using UnityOpenFeature.Core;
using UnityOpenFeature.Telemetry;
using Xunit;

namespace Spotify.Confidence.Sdk.Tests.Telemetry;

public class UnityTelemetryTests
{
[Fact]
public void TakeSnapshot_UsesCanonicalJsonValues()
{
var telemetry = new UnityOpenFeature.Telemetry.Telemetry(Platform.Unity, "1.2.3");
telemetry.TrackEvaluation(EvaluationReason.Error, EvaluationErrorCode.TypeMismatch);
telemetry.TrackResolveLatency(123, RequestStatus.Success);

var snapshot = telemetry.TakeSnapshot();

Assert.NotNull(snapshot);
var payload = snapshot.ToMonitoringPayload();
Assert.Equal("PLATFORM_UNITY", payload["platform"]);
var libraries = Assert.IsType<List<Dictionary<string, object>>>(payload["libraryTraces"]);
var library = Assert.Single(libraries);
Assert.Equal("LIBRARY_OPEN_FEATURE", library["library"]);
Assert.Equal("1.2.3", library["libraryVersion"]);

var traces = Assert.IsType<List<Dictionary<string, object>>>(library["traces"]);
var request = Assert.IsType<Dictionary<string, object>>(traces[0]["requestTrace"]);
Assert.Equal("STATUS_SUCCESS", request["status"]);
var evaluation = Assert.IsType<Dictionary<string, object>>(traces[1]["evaluationTrace"]);
Assert.Equal("EVALUATION_REASON_ERROR", evaluation["reason"]);
Assert.Equal("EVALUATION_ERROR_CODE_TYPE_MISMATCH", evaluation["errorCode"]);
}

[Theory]
[InlineData(Reason.RESOLVE_REASON_MATCH, ErrorCode.None, (int)EvaluationReason.TargetingMatch, (int)EvaluationErrorCode.Unspecified)]
[InlineData(Reason.RESOLVE_REASON_NO_SEGMENT_MATCH, ErrorCode.None, (int)EvaluationReason.Default, (int)EvaluationErrorCode.Unspecified)]
[InlineData(Reason.RESOLVE_REASON_STALE, ErrorCode.None, (int)EvaluationReason.Stale, (int)EvaluationErrorCode.Unspecified)]
[InlineData(Reason.RESOLVE_REASON_FLAG_ARCHIVED, ErrorCode.None, (int)EvaluationReason.Disabled, (int)EvaluationErrorCode.Unspecified)]
[InlineData(Reason.RESOLVE_REASON_TARGETING_KEY_ERROR, ErrorCode.None, (int)EvaluationReason.Error, (int)EvaluationErrorCode.TargetingKeyMissing)]
[InlineData(Reason.ERROR, ErrorCode.TypeMismatch, (int)EvaluationReason.Error, (int)EvaluationErrorCode.TypeMismatch)]
public void MapEvaluationResult_UsesStructuredResult(
Reason reason,
ErrorCode errorCode,
int expectedReason,
int expectedErrorCode)
{
var result = UnityOpenFeature.Telemetry.Telemetry.MapEvaluationResult(reason, errorCode);

Assert.Equal((EvaluationReason)expectedReason, result.reason);
Assert.Equal((EvaluationErrorCode)expectedErrorCode, result.errorCode);
}

[Fact]
public void TakeSnapshot_CapsCombinedTraceCount()
{
var telemetry = new UnityOpenFeature.Telemetry.Telemetry(Platform.Unity, "1.2.3");
for (int i = 0; i < 75; i++)
{
telemetry.TrackEvaluation(EvaluationReason.TargetingMatch, EvaluationErrorCode.Unspecified);
telemetry.TrackResolveLatency(ulong.MaxValue, RequestStatus.Success);
}

var snapshot = telemetry.TakeSnapshot();

Assert.NotNull(snapshot);
Assert.Equal(100, snapshot.TraceCount);
}

[Fact]
public void Restore_RequeuesFailedSnapshotWithinLimit()
{
var telemetry = new UnityOpenFeature.Telemetry.Telemetry(Platform.Unity, "1.2.3");
telemetry.TrackEvaluation(EvaluationReason.TargetingMatch, EvaluationErrorCode.Unspecified);
var failedSnapshot = telemetry.TakeSnapshot();
Assert.NotNull(failedSnapshot);

telemetry.Restore(failedSnapshot);
var retriedSnapshot = telemetry.TakeSnapshot();

Assert.NotNull(retriedSnapshot);
Assert.Equal(1, retriedSnapshot.TraceCount);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,14 @@ public void Build_ReturnsCustomApplyLoggingUrl(string baseUrl, string expected)

Assert.Equal(expected, url);
}

[Theory]
[InlineData("https://resolver.test", "https://resolver.test/v1/telemetry:upload")]
[InlineData("https://resolver.test/custom/", "https://resolver.test/custom/v1/telemetry:upload")]
public void Build_ReturnsCustomTelemetryUrl(string baseUrl, string expected)
{
var url = ConfidenceEndpointUrls.Build(baseUrl, ConfidenceEndpointUrls.TelemetryPath);

Assert.Equal(expected, url);
}
}
Loading
Loading