Enforce optional group PINs on the server - #613
Open
t0ma5 wants to merge 3 commits into
Open
Conversation
Addresses spliit-app#373: PIN is no longer a client-only gate. New PINs are PBKDF2, unlock is a signed cookie, and tRPC plus CSV/JSON export require it. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pinHashis never returned to clients).PIN_SECRET). tRPC group procedures and CSV/JSON export require it.PinAttempt).Fixes #373 — the PIN is no longer a UI-only check.
Run
prisma migrate deployafter merge. SetPIN_SECRET(16+ chars) in production if any group uses a PIN.Test plan