Throw domainerror with time series #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime slice which is out of domain of the time series.
manuelma
reviewed
May 31, 2024
| t_end <= pv.value.indexes[1] && return NaN | ||
| t_start > pv.value.indexes[end] && !pv.value.ignore_year && return NaN | ||
| t_end <= pv.value.indexes[1] && throw(DomainError(pv, "Time index $t out of range!")) | ||
| t_start > pv.value.indexes[end] && !pv.value.ignore_year && throw(DomainError(pv, "Time index $t out of range!")) |
Collaborator
There was a problem hiding this comment.
I believe we rely on time series returning NaN in those cases for a lot of things - I suggest we instead error out in SpineOpt whenever we find a NaN in the replacement value.
Collaborator
There was a problem hiding this comment.
My suggestion might also be more robust in case the NaN happens to be in the middle for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw domainerror when TimeSeries ParameterValue is refenced with a time slice which is out of domain of the time series.
Related to Checking the replacement value for variables #1016
Checklist before merging