Skip to content

fix(types): make PopupModal content accept JSXElement #3728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rxri merged 4 commits into from
Mar 9, 2026
+3 −2
Merged

fix(types): make PopupModal content accept JSXElement #3728

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75480cf
fix(types): SubMenu and ButtonProps
sanoojes Mar 6, 2026
8a66040
Merge branch 'spicetify:main' into main
sanoojes Mar 8, 2026
a40215d
fix(types): add JSXElement type to PopupModal Content
sanoojes Mar 8, 2026
b06367c
update jsdoc
sanoojes Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,9 +1294,10 @@ declare namespace Spicetify {
title: string;
/**
* You can specify a string for simple text display
* or a HTML element for interactive config/setting menu
* or a HTML element for interactive config/setting menu,
* or a React JSX element for React-based components
*/
content: string | Element;
content: string | Element | React.JSX.Element;
/**
* Bigger window
*/
Expand Down