fix(types): change types for SubMenu and ButtonProps#3723
fix(types): change types for SubMenu and ButtonProps#3723rxri merged 1 commit intospicetify:mainfrom
SubMenu and ButtonProps#3723Conversation
📝 WalkthroughWalkthroughTypeScript type definitions in globals.d.ts updated to align with React event types. SubMenu methods addItem and removeItem now explicitly declare void return types, and Button event handlers now use React-prefixed event types (React.MouseEvent and React.FocusEvent) instead of bare event types. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SubMenu and ButtonProps
as per the title
Summary by CodeRabbit