add "refdoc" attribute to most pending_xrefs#14288
Open
minijackson wants to merge 1 commit intosphinx-doc:masterfrom
Open
add "refdoc" attribute to most pending_xrefs#14288minijackson wants to merge 1 commit intosphinx-doc:masterfrom
minijackson wants to merge 1 commit intosphinx-doc:masterfrom
Conversation
This adds provenance information to pending_xrefs, which was previously wrongly assumed to be the current file when resolving them. In a case where we inline all toctrees, for example for single file builders, this would always resolve to be the root document instead of the source document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Hello, and thanks for this great project!
I'm currently writing a single-file builder for Typst, and I stumbled upon a problem:
In some cases, when a an object was defined in a file and referenced from another, the reference node would have a
refidattribute, but norefuri, so my builder couldn't figure out the correct reference.I found out that it was because the
pending_xrefdidn't have arefdocattribute indicating the document where the reference was written, and the_resolve_pending_xreffunction assumes that this must be the current document, which isn't correct if we inline all toctrees.This PR adds provenance information (
refdoc) topending_xrefs.References
None?