FEAT: Initial migration to the present 🏃#25
FEAT: Initial migration to the present 🏃#25daquintero wants to merge 8 commits intosphinx-contrib:masterfrom
Conversation
|
Example here https://github.com/daquintero/sphinxcontrib-autoflex |
stephenfin
left a comment
stephenfin
left a comment
There was a problem hiding this comment.
Couple of mismatches here. Personally, I'd drop pre-commit integration entirely (and perhaps the GitHub actions integration also they're likely to get outdated pretty quickly, as we saw with the Travis configuration)
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", |
There was a problem hiding this comment.
These don't match the CI configuration. Could you update?
| follow_imports = "skip" | ||
| incremental = true | ||
| check_untyped_defs = true | ||
| warn_unused_ignores = true |
There was a problem hiding this comment.
I'd drop this. I suspect mypy is rarely used in most sphinx extensions.
|
|
||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.6" |
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.6" | ||
| pbr = "^5.5.1" |
There was a problem hiding this comment.
tbh, pbr probably isn't the best horse to back now. Could we use setuptools here?
Later actually you us poetry so this should be wholly unnecessary?
| - id: isort | ||
|
|
||
| - repo: https://github.com/asottile/black | ||
| rev: 22.3.0 # Use the latest version of black |
There was a problem hiding this comment.
This isn't the latest (none of these are). Could you bump?
2 participants
Uh oh!
There was an error while loading. Please reload this page.