Skip to content

fix: allow empty string to reset StringToString flag #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
happysnaker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow empty string to reset StringToString flag #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions string_to_string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ func newStringToStringValue(val map[string]string, p *map[string]string) *string
// Set updates the flag value from the given string, adding additional mappings or updating existing ones.
func (s *stringToStringValue) Set(val string) error {
var ss []string
// Allow empty string to reset the map to empty
if val == "" {
for k := range *s.value {
delete(*s.value, k)
}
s.changed = true
return nil
}
n := strings.Count(val, "=")
switch n {
case 0:
Expand Down
Loading