fix: move org override to org-level super admin settings#1880
Conversation
Move the admin org override (impersonation) feature from project-level settings to a dedicated org-level "Super Admin" page. Add sidebar nav item and user dropdown menu entry, both gated behind isAdmin. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Devin Review found 3 potential issues.
⚠️ 1 issue in files not directly in the diff
⚠️ New admin-settings org route missing from ORG_ROUTE_PATHS backwards-compat redirect guard (client/dashboard/src/contexts/Auth.tsx:234-240)
The ORG_ROUTE_PATHS list in client/dashboard/src/contexts/Auth.tsx:234-240 is a hardcoded safeguard that prevents org-level URL segments from being mistakenly treated as project slugs during the backwards-compat redirect (/:orgSlug/:projectSlug/... → /:orgSlug/projects/:projectSlug/...). The new admin-settings route added in client/dashboard/src/routes.tsx:550-555 is not included in this list. If a project happens to have the slug "admin-settings", navigating to /:orgSlug/admin-settings will be incorrectly redirected to /:orgSlug/projects/admin-settings, making the admin settings page unreachable.
View 2 additional findings in Devin Review.
…display - Remove duplicate admin override form from project-menu.tsx (now lives in org-level Super Admin page) - Keep org/project ID display in project-menu for quick reference - Restore org ID and project ID display in project Settings admin section Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Devin Review found 3 new potential issues.
⚠️ 1 issue in files not directly in the diff
⚠️ New admin-settings org route missing from ORG_ROUTE_PATHS backwards-compat redirect guard (client/dashboard/src/contexts/Auth.tsx:234-240)
The ORG_ROUTE_PATHS list in client/dashboard/src/contexts/Auth.tsx:234-240 is a hardcoded safeguard that prevents org-level URL segments from being mistakenly treated as project slugs during the backwards-compat redirect (/:orgSlug/:projectSlug/... → /:orgSlug/projects/:projectSlug/...). The new admin-settings route added in client/dashboard/src/routes.tsx:550-555 is not included in this list. If a project happens to have the slug "admin-settings", navigating to /:orgSlug/admin-settings will be incorrectly redirected to /:orgSlug/projects/admin-settings, making the admin settings page unreachable.
View 3 additional findings in Devin Review.
Summary
/:orgSlug/admin-settingsRegistryCacheSectionin project settings (it requires project-scoped auth context)Test plan
/admin-settingsRegistryCacheSectionstill works in project-level settings for admins🤖 Generated with Claude Code
Resolves AGE-1581