Skip to content

fix: move overflow-y scroll to wrapper div for API keys table #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simplesagar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: move overflow-y scroll to wrapper div for API keys table #1706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 31 additions & 30 deletions client/dashboard/src/pages/settings/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,36 +320,37 @@ export default function Settings() {
className="w-64"
/>
</Stack>
<Table
columns={apiKeyColumns}
data={filteredKeys}
rowKey={(row) => row.id}
className="max-h-[500px] overflow-y-auto"
noResultsMessage={
<Stack
gap={2}
className="h-full p-4 bg-background"
align="center"
justify="center"
>
<Type variant="body">
{apiKeySearch ? "No matching API keys" : "No API keys yet"}
</Type>
{!apiKeySearch && (
<Button
size="sm"
variant="secondary"
onClick={() => setIsCreateDialogOpen(true)}
>
<Button.LeftIcon>
<Icon name="key-round" className="h-4 w-4" />
</Button.LeftIcon>
<Button.Text>Create Key</Button.Text>
</Button>
)}
</Stack>
}
/>
<div className="max-h-[500px] overflow-y-auto rounded-lg border border-border">
<Table
columns={apiKeyColumns}
data={filteredKeys}
rowKey={(row) => row.id}
noResultsMessage={
<Stack
gap={2}
className="h-full p-4 bg-background"
align="center"
justify="center"
>
<Type variant="body">
{apiKeySearch ? "No matching API keys" : "No API keys yet"}
</Type>
{!apiKeySearch && (
<Button
size="sm"
variant="secondary"
onClick={() => setIsCreateDialogOpen(true)}
>
<Button.LeftIcon>
<Icon name="key-round" className="h-4 w-4" />
</Button.LeftIcon>
<Button.Text>Create Key</Button.Text>
</Button>
)}
</Stack>
}
/>
</div>

<Dialog
open={isCreateDialogOpen}
Expand Down
Loading