Skip to content

Add methods to sort license JSON and license JSON TOC#430

Merged
goneall merged 2 commits into
spdx:masterfrom
bact:sort-crossref
Jun 28, 2026
Merged

Add methods to sort license JSON and license JSON TOC#430
goneall merged 2 commits into
spdx:masterfrom
bact:sort-crossref

Conversation

@bact

@bact bact commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

To get more stable JSON output

Note

For LicenseListPublisher, to sort crossRef in the JSON output, apply spdx/LicenseListPublisher#244 after the change is this PR is released.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact requested a review from goneall June 26, 2026 23:58
@bact bact added the enhancement New feature or request label Jun 26, 2026
@bact

bact commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator Author

Should I add sort for LicenseJsonTOC and ExceptionJsonTOC in this PR too? Both are small.

@pmonks

pmonks commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

@bact seems to me that deterministic ordering of all elements may be important.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact changed the title Sort crossRef by order and url Add methods to sort license JSON and license JSON TOC Jun 27, 2026

@goneall goneall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@goneall goneall merged commit 6a0f7b8 into spdx:master Jun 28, 2026
1 check passed
@bact bact deleted the sort-crossref branch June 28, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants