Skip to content

remove unused and buggy test code - #2415

Open
braingram wants to merge 1 commit into
spacetelescope:mainfrom
braingram:rm_unused
Open

remove unused and buggy test code#2415
braingram wants to merge 1 commit into
spacetelescope:mainfrom
braingram:rm_unused

Conversation

@braingram

@braingram braingram commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

data_glob is buggy (spacetelescope/jwst#10773) and is unused here in romancal. This PR removes the unused data_glob and other unused data_glob code. If at a later point code like this is needed the up-to-date (and hopefully less-buggy) jwst version could be brought over.

Regtests all pass:
https://github.com/spacetelescope/RegressionTests/actions/runs/31731300565

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks existing functionality, also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.31%. Comparing base (f79401d) to head (7e17fd4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
+ Coverage   82.87%   83.31%   +0.44%     
==========================================
  Files         131      131              
  Lines        7265     7218      -47     
==========================================
- Hits         6021     6014       -7     
+ Misses       1244     1204      -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram
braingram marked this pull request as ready for review August 13, 2026 20:17
@braingram
braingram requested a review from a team as a code owner August 13, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant