Skip to content

remove _is_wcs_correction_small test - #10354

Merged
emolter merged 1 commit into
spacetelescope:mainfrom
mcara:remove_is_wcs_correction_small_test
Mar 20, 2026
Merged

remove _is_wcs_correction_small test#10354
emolter merged 1 commit into
spacetelescope:mainfrom
mcara:remove_is_wcs_correction_small_test

Conversation

@mcara

@mcara mcara commented Mar 19, 2026

Copy link
Copy Markdown
Member

This PR removes unit test for a private stcal method _is_wcs_correction_small and addresses spacetelescope/stcal#529 (comment) by @braingram

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emolter emolter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it does indeed seem this test should have been removed when tweakreg went to stcal

@emolter
emolter merged commit a839859 into spacetelescope:main Mar 20, 2026
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants