Skip to content

Comments

Fix fallbacks not being used in the launcher on 500 class errors#253

Open
VasilisThePikachu wants to merge 2 commits intospace-wizards:masterfrom
VasilisThePikachu:sus
Open

Fix fallbacks not being used in the launcher on 500 class errors#253
VasilisThePikachu wants to merge 2 commits intospace-wizards:masterfrom
VasilisThePikachu:sus

Conversation

@VasilisThePikachu
Copy link
Member

@VasilisThePikachu VasilisThePikachu commented Dec 1, 2025

This is really the best way i can think of solving the issue from #252, a 500 is 100% something going wrong and the fallback needs to be attempted.

If you have better suggestion to make this more reliable please suggest it.

I think if both main and fallback 500 here the launcher will crash again though...

This is really the best way i can think of solving this, a 500 is 100% something going wrong.

If you have better suggestion to make this more reliable please suggest it.
@PJB3005
Copy link
Member

PJB3005 commented Dec 2, 2025

I think if both main and fallback 500 here the launcher will crash again though...

So uhm, you didn't test this?

@VasilisThePikachu
Copy link
Member Author

VasilisThePikachu commented Dec 19, 2025

I think if both main and fallback 500 here the launcher will crash again though...

So uhm, you didn't test this?

image Admitibly yes until now (My internet had cut out the day you sent this comment and i forgot until now to actually respond)

The reason I did not test it is that this is "intended" (note the quotes) is because of this, this is the exception i screenshoted above.

if (successTask == null)
{
// We didn't get a single successful connection. Well heck.
throw new AggregateException(
allTasks.Where(x => x.IsFaulted).SelectMany(x => x.Exception!.InnerExceptions));
}

Should this be causing a launcher crash... probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants