Fix fallbacks not being used in the launcher on 500 class errors#253
Open
VasilisThePikachu wants to merge 2 commits intospace-wizards:masterfrom
Open
Fix fallbacks not being used in the launcher on 500 class errors#253VasilisThePikachu wants to merge 2 commits intospace-wizards:masterfrom
VasilisThePikachu wants to merge 2 commits intospace-wizards:masterfrom
Conversation
)" (space-wizards#252) This reverts commit 892d95e.
This is really the best way i can think of solving this, a 500 is 100% something going wrong. If you have better suggestion to make this more reliable please suggest it.
Member
So uhm, you didn't test this? |
Member
Author
Admitibly yes until now (My internet had cut out the day you sent this comment and i forgot until now to actually respond)
The reason I did not test it is that this is "intended" (note the quotes) is because of this, this is the exception i screenshoted above. SS14.Launcher/SS14.Launcher/HappyEyeballsHttp.cs Lines 248 to 253 in 171b5d1 Should this be causing a launcher crash... probably not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is really the best way i can think of solving the issue from #252, a 500 is 100% something going wrong and the fallback needs to be attempted.
If you have better suggestion to make this more reliable please suggest it.
I think if both main and fallback 500 here the launcher will crash again though...