Simplify generated code check in AccessAnalyzer#6581
Open
Tayrtahn wants to merge 1 commit into
Open
Conversation
Tayrtahn
added
T: Performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccessAnalyzercurrently handles auto-generated code by examining the generated files normally and doing an attribute lookup on every access attempt within them to check for theRobustAutoGeneratedAttribute. This is slow and relies on all generated code remembering to apply the attribute.Instead of doing all that, this PR changes the
GeneratedCodeAnalysisFlagstoNoneinstead ofAnalyze | ReportDiagnostics.On my machine, this reduced the execution time of
AccessAnalyzerwhen packaging Content.Server from ~3.5 seconds (the slowest of our analyzers) to ~0.5 seconds.