Obsolete Button's StyleClassButton#6569
Open
Aeshus wants to merge 1 commit into
Open
Conversation
The Matches() thing already would capture if it you did Element<Button>, so having a styleclass here is only really to make it easier to skip actually scoping controls. If you want multiple things to look like buttons, either they should inherit from the same base or the code be duplicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Obsoleted the
StyleClassButtonstring defined inContainerButtonand used inButtonand in random places in content.Why / Balance
RT shouldn't be defining StyleClasses to style these buttons. This should be something that people decide within content if they'd like to use StyleClasses, but we shouldn't be adding an extra way to duplicate a style across multiple ContainerButton child classes when the content Stylesheet creator can do that themselves without dirtying up RT code.
(There's also just better ways to do these selectors than using this StyleClass.)
Media
N/A
Migration(s)
Switch to
E<T>selectors (they support inheritance), and switch to Parent/Child selectors for the Label.E<Button>.Class(ContainerButton.StyleClassButton)is the same asE<Button>.Changes
Obsoleted the
StyleClassButtonstring.