Skip to content

BroadPhaseSystem & GridFixtureSystem clean up#6565

Open
TheShuEd wants to merge 8 commits into
space-wizards:masterfrom
TheShuEd:ed-12-05-2026-broadphase-clean-up
Open

BroadPhaseSystem & GridFixtureSystem clean up#6565
TheShuEd wants to merge 8 commits into
space-wizards:masterfrom
TheShuEd:ed-12-05-2026-broadphase-clean-up

Conversation

@TheShuEd
Copy link
Copy Markdown
Member

file-scoping,
EntityQuery dependency injection
makes dependencies readonly

Again, I'm not changing the underlying logic; I'm just removing outdated style and updating the code to meet modern standards

@TheShuEd TheShuEd changed the title BroadPhaseSystem clean up BroadPhaseSystem & GridFixtureSystem clean up May 12, 2026
@TheShuEd
Copy link
Copy Markdown
Member Author

GridSplitEvent as a result of this change, it ended up inside the system namespace (which is correct, in theory).

But the content, of course, doesn't know this.

I don’t quite understand exactly how we should handle situations like this:

Changing the namespace in the content will also cause errors without changing the engine, and changing the engine will cause errors in the content. I can certainly create a PR with a fix for the content, but should these changes be merged simultaneously? That doesn’t feel right. How is this handled?

@slarticodefast
Copy link
Copy Markdown
Member

I can certainly create a PR with a fix for the content, but should these changes be merged simultaneously? That doesn’t feel right. How is this handled?

Make a content PR that fixes the namespace import and write requires https://github.com/space-wizards/RobustToolbox/pull/6565 into the Pr description so that it uses this engine branch so that the tests can pass. It will then be merged along with the next engine release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants