You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GridSplitEvent as a result of this change, it ended up inside the system namespace (which is correct, in theory).
But the content, of course, doesn't know this.
I don’t quite understand exactly how we should handle situations like this:
Changing the namespace in the content will also cause errors without changing the engine, and changing the engine will cause errors in the content. I can certainly create a PR with a fix for the content, but should these changes be merged simultaneously? That doesn’t feel right. How is this handled?
I can certainly create a PR with a fix for the content, but should these changes be merged simultaneously? That doesn’t feel right. How is this handled?
Make a content PR that fixes the namespace import and write requires https://github.com/space-wizards/RobustToolbox/pull/6565 into the Pr description so that it uses this engine branch so that the tests can pass. It will then be merged along with the next engine release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file-scoping,
EntityQuery dependency injection
makes dependencies readonly
Again, I'm not changing the underlying logic; I'm just removing outdated style and updating the code to meet modern standards