Normal/Hover/Focus PseudoClasses for TextEdit & LineEdit#6558
Open
Aeshus wants to merge 3 commits into
Open
Conversation
I don't think this breaks any code, and now you can rely on KeyboardFocused() to tell if you're taking user input for style purposes
If TextEdit uses NotEditable, might as well use it here too. It's also now the same as the old StyleClass but a PseudoClass
PJB3005
added
T: New Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
There are new
Normal/Hover/Focus/NotEditablepseudoclasses available within TextEdit/LineEdit (alongsidePlaceholder).Why / Balance
I wanted to style TextEdit/LineEdit more in content.
There's no way to style in Content when a TextEdit/LineEdit is being hovered or being edited, so this now lets you style it.
Media
New (style changes to show behavior):
new-updated.mp4
New (no style changes):
new.mp4
Old:
old.mp4
Migration(s)
No breaking style changes unless there are badly written stylerules, such as in space-wizards/space-station-14#43908.
Changes
New obsolete warning on using
LineEdit'sStylePseudoClassNotEditableinstead ofStylePseudoClassLineEditNotEditable, though support for it is still implemented.KeyboardFocusedis now cleared before callingKeyboardFocusExited()so it can be used for pseudoclass styling.Support for
Normal/Hover/Focus/NotEditablepseudoclasses that are mutually exclusive and can compose with thePlaceholderPseudoclass.