Test building content master against engine in release configuration - #6557
Merged
metalgearsloth merged 3 commits intoJul 16, 2026
Merged
Conversation
PJB3005
suggested changes
May 8, 2026
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
Is this just a copy of test-content.yml that doesn't run tests? Wouldn't it be easier to just run the build twice in that workflow?
Contributor
Author
|
Yeah, probably. I'll do that. |
Contributor
Author
|
In retrospect, this might be better as a separate action so it doesn't stop the tests from running when there's an unavoidable warning. |
RavenAzala
pushed a commit
to Echo-DreamMaker/RobustToolbox
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds step to the
test-contentGH workflow to do a Release build of the latest content master using the PR'd changes to the engine. The existing check that builds and tests does so in debug configuration, which means that it misses potential problems that only show up in release builds.Notably, this gives us a heads up when adding new warning types (through analyzers), since release builds use the
TreatWarningsAsErrorsoption (I totally haven't made this mistake). This extra step lets us verify that content is prepared for such updates.