Visibility Modifiers Layers#6539
Open
Pok27 wants to merge 1 commit into
Open
Conversation
2 tasks
iaada
approved these changes
Apr 27, 2026
Member
iaada
left a comment
iaada
left a comment
There was a problem hiding this comment.
I think this is the best way to go about modifying the vismask. It enables us to not need to remember the original layer to reset it (fragile) when applying temporary effects, especially those defined through yaml.
PJB3005
reviewed
May 8, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
This seems like a really bad idea from a performance PoV? Now every time visibility has to be recalculated, it has to raise an event recursively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
RefreshVisibilityModifiersEventso that systems can modify visibility layers without affecting the base layersRequired for space-wizards/space-station-14#43706