chore: Scaffolding cleanup

[iverc]

Description

This PR includes minor fixes and cleans up unused scaffolding code/comments.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b49eae78-3c5d-423e-a3e7-1bdbe247cadc

📥 Commits

Reviewing files that changed from the base of the PR and between 64af73c and f276c6c.

📒 Files selected for processing (1)

• app/app_config.go

💤 Files with no reviewable changes (1)

• app/app_config.go

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test

---

📝 Walkthrough

Walkthrough

Cleanup and minor refactors across modules: removed scaffolding comments, deleted empty type files and unused constants/errors/interfaces, removed bulletin module BeginBlock/EndBlock hooks, and adjusted utils/sort.go slice allocation and a commented comparator line.

Changes

Cohort / File(s)	Summary
Autocli / Formatting x/acp/module/autocli.go, x/bulletin/module/autocli.go	Removed Ignite/Starport scaffold comment markers and adjusted struct literal formatting in AutoCLI Query/Tx options; no command logic changes.
Module hooks & imports x/bulletin/module/module.go, x/tier/module/module.go	Removed BeginBlock/EndBlock implementations from bulletin module and deleted a Starport scaffolding import comment in tier module.
Empty package files removed x/acp/types/types.go, x/bulletin/types/types.go, x/hub/types/types.go	Deleted files that only declared package types (no exported symbols).
Keeper interface cleanup x/acp/types/expected_keepers.go, x/bulletin/types/expected_keepers.go	Removed ParamSubspace interface definitions and stray/comments from keeper interface blocks.
Constants & sentinel errors removed x/acp/types/keys.go, x/bulletin/types/genesis.go, x/tier/types/genesis.go, x/hub/types/errors.go	Removed exported constants MemStoreKey and DefaultIndex, and removed sentinel error ErrSample; removed related scaffolding comments.
Error comment cleanup x/bulletin/types/errors.go, x/tier/types/errors.go	Removed // DONTCOVER comment lines near error registrations.
Utility sort change utils/sort.go	Sort() now allocates a slice with explicit length before copying; SortSlice() removed a commented-out comparator line only.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore: Cleanup #102 — Edits the same bulletin keys file (removal of MemStoreKey) and related collaborator key changes.

Suggested reviewers

• Lodek

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@x/bulletin/module/module.go`:
- Around line 35-36: The beginBlockers and endBlockers configuration still lists
bulletintypes.ModuleName even though the bulletin module no longer implements
HasBeginBlocker/HasEndBlocker; update the arrays in app/app_config.go by
removing the bulletintypes.ModuleName entries from the beginBlockers and
endBlockers slices so the registration matches the module's implemented
interfaces (search for beginBlockers, endBlockers and remove the
bulletintypes.ModuleName element).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 869c3596-9c69-46db-afc1-782cacba6891

📥 Commits

Reviewing files that changed from the base of the PR and between f0564ce and 64af73c.

📒 Files selected for processing (16)

• utils/sort.go
• x/acp/module/autocli.go
• x/acp/types/expected_keepers.go
• x/acp/types/keys.go
• x/acp/types/types.go
• x/bulletin/module/autocli.go
• x/bulletin/module/module.go
• x/bulletin/types/errors.go
• x/bulletin/types/expected_keepers.go
• x/bulletin/types/genesis.go
• x/bulletin/types/types.go
• x/hub/types/errors.go
• x/hub/types/types.go
• x/tier/module/module.go
• x/tier/types/errors.go
• x/tier/types/genesis.go

💤 Files with no reviewable changes (12)

• x/tier/types/errors.go
• x/bulletin/types/errors.go
• x/tier/module/module.go
• x/acp/types/keys.go
• x/hub/types/errors.go
• x/bulletin/types/expected_keepers.go
• x/hub/types/types.go
• x/bulletin/types/types.go
• x/bulletin/types/genesis.go
• x/acp/types/expected_keepers.go
• x/tier/types/genesis.go
• x/acp/types/types.go

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test

🔇 Additional comments (3)

utils/sort.go (1)

72-73: Good fix: copy target now has the correct length.

This correctly ensures copy(vals, s.ts) copies all elements before sorting, preserving Sort() as a non-mutating operation on the original slice.

x/acp/module/autocli.go (1)

75-85: LGTM!

Clean removal of Ignite scaffolding marker comments. The slice closures are correctly positioned.

x/bulletin/module/autocli.go (1)

56-62: LGTM!

Clean formatting alignment for the BulletinPolicyId command descriptor and removal of scaffolding markers.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.81%. Comparing base (f0564ce) to head (f276c6c).

Files with missing lines	Patch %	Lines
utils/sort.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #105      +/-   ##
==========================================
- Coverage   47.92%   47.81%   -0.12%     
==========================================
  Files         276      276              
  Lines       16204    16200       -4     
==========================================
- Hits         7766     7746      -20     
- Misses       7639     7655      +16     
  Partials      799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.