Skip to content

fix: Protos#104

Merged
iverc merged 1 commit intodevfrom
iverc/fix-proto
Mar 31, 2026
Merged

fix: Protos#104
iverc merged 1 commit intodevfrom
iverc/fix-proto

Conversation

@iverc
Copy link
Copy Markdown
Contributor

@iverc iverc commented Mar 31, 2026

Description

This PR fixes incorrect/missing proto definitions.

@iverc iverc requested a review from JesseAbram March 31, 2026 21:04
@iverc iverc self-assigned this Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 31, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR updates the protobuf schema for the SourceHub bulletin module by adding an artifact string field to two existing messages (EventPostCreated and MsgCreatePost), introducing two new query message types (QueryBulletinPolicyIdRequest and QueryBulletinPolicyIdResponse), and reorganizing imports in one file. All corresponding generated Go code is updated accordingly.

Changes

Cohort / File(s) Summary
Artifact field additions
api/sourcehub/bulletin/events.pulsar.go, api/sourcehub/bulletin/tx.pulsar.go
Added artifact string field to EventPostCreated and MsgCreatePost messages with full fast-reflection layer support including marshaling/unmarshaling, accessors, and field descriptors.
Query message types and RPC mapping
api/sourcehub/bulletin/query.pulsar.go
Added two new protobuf messages (QueryBulletinPolicyIdRequest and QueryBulletinPolicyIdResponse) with complete reflection implementations; updated message type indices for existing QueryIterateGlobRequest and QueryIterateGlobResponse messages.
Import organization
api/sourcehub/hub/chain_config.pulsar.go
Reordered standard library imports, moving the blank import for cosmossdk.io/api/amino above fmt.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • sourcenetwork/sourcehub#93: Adds identical artifact field to EventPostCreated and MsgCreatePost protobuf messages and generated Go code.
  • sourcenetwork/sourcehub#97: Adds the same QueryBulletinPolicyId request/response message types and RPC mapping to the query service.

Suggested reviewers

  • Lodek

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.86%. Comparing base (6393001) to head (b9877c5).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #104      +/-   ##
==========================================
+ Coverage   47.80%   47.86%   +0.05%     
==========================================
  Files         276      276              
  Lines       16196    16208      +12     
==========================================
+ Hits         7743     7758      +15     
+ Misses       7647     7645       -2     
+ Partials      806      805       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iverc iverc merged commit 7839ab2 into dev Mar 31, 2026
1 of 2 checks passed
@iverc iverc deleted the iverc/fix-proto branch March 31, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants