fix: Add exhaustive directive to npx test fixtures#4634
fix: Add exhaustive directive to npx test fixtures#4634nasdf merged 3 commits intosourcenetwork:developfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (45)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughAdds a new GraphQL directive Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4634 +/- ##
===========================================
- Coverage 76.84% 76.76% -0.08%
===========================================
Files 529 529
Lines 42793 42793
===========================================
- Hits 32880 32847 -33
- Misses 7411 7434 +23
- Partials 2502 2512 +10
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fredcarle
left a comment
There was a problem hiding this comment.
LGTM. Please create an issue an link it to the PR. It would be good to document why this is needed within the issue description.
Relevant issue(s)
Resolves: #4667
Description
This PR fixes the npx tests by adding the missing
@exhaustivedirective to the test fixtures. We should also make the npx tests required.Tasks
How has this been tested?
make test:npxSpecify the platform(s) on which this was tested: